linux-kernel - Re: [PATCH 5/5] PCI-Express AER implemetation: pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060724193752.GD7448@austin.ibm.com>
Date:	Mon, 24 Jul 2006 14:37:52 -0500
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Greg KH <greg@...ah.com>,
	Tom Long Nguyen <tom.l.nguyen@...el.com>
Subject: Re: [PATCH 5/5] PCI-Express AER implemetation: pcie_portdrv error handler

Hi,

Sorry for a late reply...

On Fri, Jul 14, 2006 at 01:35:38PM +0800, Zhang, Yanmin wrote:
> 
> --- linux-2.6.17/drivers/pci/pcie/portdrv_pci.c	2006-06-22 16:27:35.000000000 +0800
> +++ linux-2.6.17_aer/drivers/pci/pcie/portdrv_pci.c	2006-06-22 16:46:29.000000000 +0800
> +
> +static pci_ers_result_t pcie_portdrv_error_detected(struct pci_dev *dev,
> +					enum pci_channel_state error)
> +{
> +	/* If fatal, save cfg space for possible link reset at upstream */
> +	if (error == pci_channel_io_frozen)
> +		pcie_portdrv_save_config(dev);

If the channel is frozen, is the config space still readable? 
In my case, I had to save config space data early on before
the bus error. 

What's more, I discovered that I had to save the pci config 
space data before device drivers do thier probe. During the probe, 
device drivers will change the config. For example, they'll enable
interrupts and dma. If you turn these on, and then do the probe,
you'll get spectacuar failures.

To be safe, I found the best thing to do was to save the pci
config space state as it was during boot, before the PCI probe 
routines ran.

--linas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/