linux-kernel - [PATCH] Sane return value for ecryptfs_commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20060720193419.GA12086@us.ibm.com>
Date:	Thu, 20 Jul 2006 14:34:19 -0500
From:	Michael Halcrow <mhalcrow@...ibm.com>
To:	akpm@...l.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] Sane return value for ecryptfs_commit_write()

Calling functions expect the return value from ecryptfs_commit_write()
to be 0 on success.

Signed-off-by: Michael Halcrow <mhalcrow@...ibm.com>

---

 fs/ecryptfs/mmap.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

9c56c9f6f49840860068b461c1d956391cbc5550
diff --git a/fs/ecryptfs/mmap.c b/fs/ecryptfs/mmap.c
index 65e7331..8a4040d 100644
--- a/fs/ecryptfs/mmap.c
+++ b/fs/ecryptfs/mmap.c
@@ -628,7 +628,6 @@ static int ecryptfs_commit_write(struct 
 {
 	struct ecryptfs_page_crypt_context ctx;
 	loff_t pos;
-	unsigned bytes = to - from;
 	struct inode *inode;
 	struct inode *lower_inode;
 	struct file *lower_file;
@@ -671,7 +670,7 @@ static int ecryptfs_commit_write(struct 
 				"index [0x%.16x])\n", page->index);
 		goto out;
 	}
-	rc = bytes;
+	rc = 0;
 	inode->i_blocks = lower_inode->i_blocks;
 	pos = (page->index << PAGE_CACHE_SHIFT) + to;
 	if (pos > i_size_read(inode)) {
-- 
1.3.3

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/