linux-kernel - Re: [PATCH 6/6] cpuid neatening.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44C55E8F.2020200@zytor.com>
Date:	Mon, 24 Jul 2006 16:58:07 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Andi Kleen <ak@....de>, Andrew Morton <akpm@...l.org>,
	Keir Fraser <Keir.Fraser@...cam.ac.uk>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Zachary Amsden <zach@...are.com>, Pratap <pratap@...are.com>,
	Chris Wright <chrisw@...s-sol.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] cpuid neatening.

Rusty Russell wrote:
> Roll all the cpuid asm into one __cpuid call.  It's a little neater,
> and also means only one place to patch for paravirtualization.

The whole point of those is to avoid the unnecessary write to memory and 
pick it back up again.  This patch reintroduces that ugliness.

You don't want to make it the obvious multi-return macro, either, 
because that code is known to break some old versions of gcc.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/