lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Jul 2006 19:16:00 -0700 (PDT) From: Trent Piepho <xyzzy@...akeasy.org> To: Mauro Carvalho Chehab <mchehab@...radead.org> cc: v4l-dvb maintainer list <v4l-dvb-maintainer@...uxtv.org>, Linux and Kernel Video <video4linux-list@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [v4l-dvb-maintainer] Re: [PATCH] V4L: struct video_device corruption On Sun, 23 Jul 2006, Mauro Carvalho Chehab wrote: > Ok, I had some time to fix the broken dependencies. Please look at the > two commits I did today. Two things I noticed. bttv didn't use to _require_ V4L1. I use bttv and have V4L1 turned off. I guess this is just because bttv ignored the V4L1 setting? Second, the fix for class_device_create_file() doesn't roll-back properly on failure. I already posted a patch which does this correctly. Attached is the patch against the current Hg, go ahead and import it. Also attached is patch to bttv-driver.c that has it use class_device_create_file(), with an error message and handling of failure. > One patch removes HAVE_V4L1 check at drivers. It also include some checks for > V4L1_COMPAT on some core files that should implement both calls to provide > support for V4L1 drivers. > > The other fixes the broken dependencies for drivers that still need V4L1 > to work properly. > > Cheers, > Mauro. > > Em Sex, 2006-07-21 ās 15:55 -0700, Trent Piepho escreveu: > > On Fri, 21 Jul 2006, Mauro Carvalho Chehab wrote: > > > config VIDEO_BT848 > > > tristate "BT848 Video For Linux" > > > depends on VIDEO_DEV && PCI && I2C && VIDEO_V4L2 > > > > > > Argh! it should be V4L1 instead! > > > > You can compile and use bt848 without V4L1 turned on. It still has some > > V4L1 functions defined. > > > > > > All these files include v4l2-dev.h and have HAVE_V4L1 defined when V4L1 is > > > > not turned on in Kconfig. There files are all buildable when V4L1 is off; > > > > they don't depend on it in Kconfig. > > > Some of the above drivers are V4L2, like tda9887, tuner-core, > > > tuner-simple, msp3400, cs53l32a, tveeprom, wm87xx. Maybe they are just > > > including the wrong headers. We should try to change to videodev2.h and > > > see what happens with all those drivers. The ones that break should me > > > marked with the proper requirement on Kconfig. > > > > > > Some of they need some #ifdef inside. For example, compat_ioctl32 should > > > handle both APIs, since it is a generic code to fix 32 bit calls to 64 > > > bit kernel. > > > > I think this is pretty much what I've been saying. Drivers should: > > A. Not include videodev.h, but use videodev2.h > > B. Include videodev.h, but be marked V4L1 in Kconfig > > C. #ifdef around videodev.h (and code that needs videodev.h), so it > > is not included or needed when V4L1 is turned off. > Cheers, > Mauro. > > View attachment "cdcf_videodev.patch" of type "TEXT/PLAIN" (2823 bytes) View attachment "cdcf_bttv.patch" of type "TEXT/PLAIN" (1424 bytes)
Powered by blists - more mailing lists