linux-kernel - Re: [PATCH 3/3] kconfig/lxdialog: add bluetitle color scheme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060724131528.GB23210@mars.ravnborg.org>
Date:	Mon, 24 Jul 2006 15:15:28 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Roman Zippel <zippel@...ux-m68k.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 3/3] kconfig/lxdialog: add bluetitle color scheme

On Mon, Jul 24, 2006 at 02:28:24PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Mon, 24 Jul 2006, Sam Ravnborg wrote:
> 
> > +static void set_bluetitle_theme(void)
> > +{
> > +	DLG_MODIFY(title, COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(button_label_active, COLOR_BLUE, COLOR_BLUE,   true);
> > +	DLG_MODIFY(searchbox_title,     COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(position_indicator,  COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(tag,                 COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(tag_selected,        COLOR_BLUE, COLOR_BLUE,   true);
> > +	DLG_MODIFY(tag_key,             COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(tag_key_selected,    COLOR_BLUE, COLOR_BLUE,   true);
> > +}
> 
> In general I would like to see this one become the default, as yellow on 
> white is really terrible, but this one needs fixing too - blue on blue is 
> not really readable either. :)

I blindly replaced yellow with blue.
New version looks like this:
static void set_bluetitle_theme(void)
{
        DLG_MODIFY(title,   COLOR_BLUE, COLOR_WHITE,  true);
        DLG_MODIFY(tag,     COLOR_BLUE, COLOR_WHITE,  true);
        DLG_MODIFY(tag_key, COLOR_BLUE, COLOR_WHITE,  true);
}

The classic color scheme is quite readable on my display.

I can make bluetitle default but keep classic as an option.
Will try this in next version of the patchset.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/