linux-kernel - Re: [v4l-dvb-maintainer] Re: [PATCH] V4L: struct video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Jul 2006 11:57:11 +0400
From:	Manu Abraham <abraham.manu@...il.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Mauro Carvalho Chehab <mchehab@...radead.org>, robfitz@...k.net,
	video4linux-list@...hat.com, 76306.1226@...puserve.com,
	fork0@...nline.de, greg@...ah.com, linux-kernel@...r.kernel.org,
	rdunlap@...otime.net, v4l-dvb-maintainer@...uxtv.org,
	shemminger@...l.org
Subject: Re: [v4l-dvb-maintainer] Re: [PATCH] V4L: struct video_device corruption

Andrew Morton wrote:
> On Sat, 15 Jul 2006 22:31:04 -0300
> Mauro Carvalho Chehab <mchehab@...radead.org> wrote:
> 
>> Em Sáb, 2006-07-15 às 23:08 +0000, Robert Fitzsimons escreveu:
>>> The layout of struct video_device would change depending on whether
>>> videodev.h (V4L1) was include or not before v4l2-dev.h, which caused
>>> the structure to get corrupted.  
>> Hmm... good point! However, I the proper solution would be to trust on
>> CONFIG_VIDEO_V4L1_COMPAT or CONFIG_VIDEO_V4L1 instead. it makes no sense
>> to keep a pointer to an unsupported callback, when V4L1 is not selected.
>>
> 
> So I've lost the plot with all of this.  Does the current git-dvb contain
> the desired fixes?
> 
> Do we expect this will fix the various DVB crashes which people (including
> Alex) have reported?

I believe you are referring to the "oops in bttv" thread.

As i understood, the case that Alex reported in was a null pointer issue 
due to which modprobe bttv crashes, rather than a DVB issue.

Call Trace:
  [<c018763c>] sysfs_create_file+0x26/0x28
  [<c0220cc3>] class_device_create_file+0x14/0x1a
  [<f9bc3073>] bttv_register_video+0x8c/0x147 [bttv]
  [<f9bc35de>] bttv_probe+0x4ab/0x593 [bttv]


Therefore the V4L fixes should probably fix the same as well.


Regards,
Manu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/