lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060725210953.GA11405@martell.zuzino.mipt.ru>
Date:	Wed, 26 Jul 2006 01:09:53 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com
Subject: Re: [RFC PATCH] Multi-threaded device probing

On Tue, Jul 25, 2006 at 01:30:28PM -0700, Greg KH wrote:
> This adds the infrastructure for drivers to do a threaded probe.

> -			goto ProbeFailed;
> +			goto probe_failed;
>  		}
>  	} else if (drv->probe) {
>  		ret = drv->probe(dev);
>  		if (ret) {
>  			dev->driver = NULL;
> -			goto ProbeFailed;
> +			goto probe_failed;
>  		}
>  	}
>  	device_bind_driver(dev);
>  	ret = 1;
>  	pr_debug("%s: Bound Device %s to Driver %s\n",
>  		 drv->bus->name, dev->bus_id, drv->name);
> -	goto Done;
> +	goto done;
>  
> - ProbeFailed:
> +probe_failed:
>  	if (ret == -ENODEV || ret == -ENXIO) {
>  		/* Driver matched, but didn't support device
>  		 * or device not found.
> @@ -110,7 +99,53 @@ int driver_probe_device(struct device_dr
>  		       "%s: probe of %s failed with error %d\n",
>  		       drv->name, dev->bus_id, ret);
>  	}
> - Done:
> +done:

Removing these changes will make this patch smaller and do one thing. ;-)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ