linux-kernel - [PATCH] sonypi: Don't print driver version until we actually find a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200607251637.19017.bjorn.helgaas@hp.com>
Date:	Tue, 25 Jul 2006 16:37:18 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Stelian Pop <stelian@...ies.net>, linux-kernel@...r.kernel.org
Subject: [PATCH] sonypi: Don't print driver version until we actually find a device

If we don't find any devices, we shouldn't print anything.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>

Index: work-mm2/drivers/char/sonypi.c
===================================================================
--- work-mm2.orig/drivers/char/sonypi.c	2006-07-17 16:50:45.000000000 -0600
+++ work-mm2/drivers/char/sonypi.c	2006-07-19 16:40:34.000000000 -0600
@@ -1528,13 +1528,13 @@
 {
 	int error;
 
+	if (!dmi_check_system(sonypi_dmi_table))
+		return -ENODEV;
+
 	printk(KERN_INFO
 		"sonypi: Sony Programmable I/O Controller Driver v%s.\n",
 		SONYPI_DRIVER_VERSION);
 
-	if (!dmi_check_system(sonypi_dmi_table))
-		return -ENODEV;
-
 	error = platform_driver_register(&sonypi_driver);
 	if (error)
 		return error;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/