[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20060724212911.32dd3bc0.akpm@osdl.org>
Date: Mon, 24 Jul 2006 21:29:11 -0700
From: Andrew Morton <akpm@...l.org>
To: Edgar Hucek <hostmaster@...soft.at>
Cc: torvalds@...l.org, ebiederm@...ssion.com, hpa@...or.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Add efi e820 memory mapping on x86 [try #1]
On Sun, 16 Jul 2006 10:55:30 +0200
Edgar Hucek <hostmaster@...soft.at> wrote:
> This Patch add an efi e820 memory mapping.
>
Why?
> /*
> + * Make a e820 memory map
> + */
> +void __init efi_init_e820_map(void)
> +{
> + efi_memory_desc_t *md;
> + unsigned long long start = 0;
> + unsigned long long end = 0;
> + unsigned long long size = 0;
I guess these should have type resource_size_t, given that they ultimately
get remembered via request_resource(). But that has a good chance of
breaking something, so let's leave it alone.
> + add_memory_region(md->phys_addr, md->num_pages <<
> EFI_PAGE_SHIFT, E820_ACPI);
The patch is wordwrapped and will not apply.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists