linux-kernel - Re: [patch] slab: always follow arch requested alignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0607261443150.17986@sbz-30.cs.Helsinki.FI>
Date:	Wed, 26 Jul 2006 14:48:04 +0300 (EEST)
From:	Pekka J Enberg <penberg@...Helsinki.FI>
To:	Christoph Lameter <clameter@....com>
cc:	Heiko Carstens <heiko.carstens@...ibm.com>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [patch] slab: always follow arch requested alignments

On Wed, 26 Jul 2006, Christoph Lameter wrote:
> If you disable them then we are fine. I think the main "bug" is that 
> we create the caches with ARCH_KMALLOC_MINALIGN in kmem_cache_init but 
> allow debug options on them. It seemss that we need to be able to disable 
> debugging from kmem_cache_init.

No, as Heiko explained, but bug is that we fail to respect architecture 
and caller mandated alignment when CONFIG_SLAB_DEBUG is enabled. With this 
patch (or Heiko's), we should be okay: http://lkml.org/lkml/2006/7/26/93

Note that this will fix the kmem_cache_init() case too. If 
ARCH_KMALLOC_MINALIGN is greater than BYTES_PER_WORD, we'll disable 
debugging for those caches. It's obviously ok to have debugging for 
kmem_cache_init caches too if ARCH_KMALLOC_MINALIGN is greater than or 
equal to BYTES_PER_WORD.

					Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/