[<prev] [next>] [day] [month] [year] [list]
Message-Id: <200607261737.56481.mb@bu3sch.de>
Date: Wed, 26 Jul 2006 17:37:56 +0200
From: Michael Buesch <mb@...sch.de>
To: Andrew Morton <akpm@...l.org>
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] hwrng: fix geode probe error unwind
The geode hwrng leaks an iomapped resource, if hwrng_register() failes.
This fixes it.
Signed-off-by: Michael Buesch <mb@...sch.de>
Index: linux-2.6/drivers/char/hw_random/geode-rng.c
===================================================================
--- linux-2.6.orig/drivers/char/hw_random/geode-rng.c 2006-07-26 17:35:13.000000000 +0200
+++ linux-2.6/drivers/char/hw_random/geode-rng.c 2006-07-26 17:36:52.000000000 +0200
@@ -107,10 +107,14 @@
if (err) {
printk(KERN_ERR PFX "RNG registering failed (%d)\n",
err);
- goto out;
+ goto err_unmap;
}
out:
return err;
+
+err_unmap:
+ iounmap(mem);
+ goto out;
}
static void __exit mod_exit(void)
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists