linux-kernel - Re: [NFS] [PATCH] [nfsd] Add lock annotations to e_start and e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1153901976.3381.1.camel@laptopd505.fenrus.org>
Date:	Wed, 26 Jul 2006 10:19:35 +0200
From:	Arjan van de Ven <arjan@...radead.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Josh Triplett <josht@...ibm.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>, nfs@...ts.sourceforge.net,
	Neil Brown <neilb@....unsw.edu.au>
Subject: Re: [NFS] [PATCH] [nfsd] Add lock annotations to e_start and e_stop

On Wed, 2006-07-26 at 09:06 +0100, Christoph Hellwig wrote:
> On Tue, Jul 25, 2006 at 08:20:24AM -0700, Josh Triplett wrote:
> > e_start acquires svc_export_cache.hash_lock, and e_stop releases it.  Add lock
> > annotations to these two functions so that sparse can check callers for lock
> > pairing, and so that sparse will not complain about these functions since they
> > intentionally use locks in this manner.
> > 
> > Signed-off-by: Josh Triplett <josh@...edesktop.org>
> 
> The Signed-off-by: line doesn't match the from line of this mail.  Is that
> any problem or fine in general?

As far as I can see it's customary for the SOB line to state the
affiliation of the person, eg the company that wants to own the
copyright on the code. So I'd expect Josh to use his ibm.com account...

Greetings,
   Arjan van de Ven


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/