linux-kernel - Re: Require mmap handler for a.out executables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0607270816500.4168@g5.osdl.org>
Date:	Thu, 27 Jul 2006 08:18:19 -0700 (PDT)
From:	Linus Torvalds <torvalds@...l.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	Marcel Holtmann <marcel@...tmann.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Eugene Teo <eteo@...hat.com>
Subject: Re: Require mmap handler for a.out executables



On Thu, 27 Jul 2006, Christoph Hellwig wrote:
>
> > diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> > index f312103..5638acf 100644
> > --- a/fs/binfmt_aout.c
> > +++ b/fs/binfmt_aout.c
> > @@ -278,6 +278,9 @@ static int load_aout_binary(struct linux
> >  		return -ENOEXEC;
> >  	}
> >  
> > +	if (!bprm->file->f_op || !bprm->file->f_op->mmap)
> > +		return -ENOEXEC;
> > +
> 
> These checks need a big comment explanining why they are there, else people
> will remove them again by accident.

Since we fixed the /proc problem in a different way, I decided that it 
might be best to leave the a.out stuff alone, at least for now. It is 
conceivable that somebody actually might be using executables on some 
strange filesystem that doesn't support mmap, although I can't for the 
moment think of any good reason. 

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/