linux-kernel - Re: [PATCH]: Add check return result while call create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0607271002510.7955@shark.he.net>
Date:	Thu, 27 Jul 2006 10:04:34 -0700 (PDT)
From:	"Randy.Dunlap" <rdunlap@...otime.net>
To:	"Randy.Dunlap" <rdunlap@...otime.net>
cc:	Joe Jin <lkmaillist@...il.com>, Linus Torvalds <torvalds@...l.org>,
	Andrew Morton <akpm@...l.org>, ipw2100-admin@...ux.intel.com,
	linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>,
	wim.coekaerts@...cle.com, wangwengang1976@...il.com
Subject: Re: [PATCH]: Add check return result while call create_workqueue()
 for ipw2200

On Thu, 27 Jul 2006, Randy.Dunlap wrote:

> On Thu, 27 Jul 2006, Joe Jin wrote:
>
> > Add check return result on call create_workqueue().
> >
> > Signed-off-by: Joe Jin <lkmaillist@...il.com>
> > ---
> >
> > --- linux-2.6.17.7/drivers/net/wireless/ipw2200.c       2006-07-27
> > 20:27:01.000000000 +0800
> > +++ linux.new/drivers/net/wireless/ipw2200.c    2006-07-27
> > 20:28:22.000000000 +0800
> > @@ -10139,6 +10139,9 @@
> >         int ret = 0;
> >
> >         priv->workqueue = create_workqueue(DRV_NAME);
> > +       if(NULL == priv->workqueue){
> > +               return -ENOMEM;
> > +       }
>
> Makes sense, but style needs some changes:
>
> a.  space after "if"
> b.  put NULL on righth side of ==, or use !priv->workqueue
> c.  no {} braces for one-line "blocks"
> d.  if braces were being used, put a space between ) and {
>
> And <ret> is useless (not needed) in that function unless the code
> is changed to have a single exit point.

One more thing:  the patch is whitespace-damaged.  Something
converted all tabs to spaces.  Could have been a mail client
or copy-and-paste...  Did you use the gmail web interface
or gmail via SMTP?  gmail web interface does not preserve
tabs AFAIK.

> >         init_waitqueue_head(&priv->wait_command_queue);
> >         init_waitqueue_head(&priv->wait_state);
> >

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/