linux-kernel - Re: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_trans_delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060728092035.C2196410@wobbly.melbourne.sgi.com>
Date:	Fri, 28 Jul 2006 09:20:36 +1000
From:	Nathan Scott <nathans@....com>
To:	Josh Triplett <josht@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	xfs@....sgi.com
Subject: Re: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_trans_delete_ail

On Wed, Jul 26, 2006 at 11:25:23AM -0700, Josh Triplett wrote:
> xfs_trans_update_ail and xfs_trans_delete_ail get called with the AIL lock
> held, and release it.  Add lock annotations to these two functions (abstracted
> like the AIL lock itself) so that sparse can check callers for lock pairing,
> and so that sparse will not complain about these functions since they
> intentionally use locks in this manner.

Thanks Josh, looks good - I'll get it merged.  I'd prefer to just
open code the use of __acquires/__releases for clarity, but I can
easily make that change before merging.

cheers.

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/