linux-kernel - Re: [PATCH] ncpfs: move ioctl32 code to fs/ncpfs/ioctl.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200607270745.42622.arnd.bergmann@de.ibm.com>
Date:	Thu, 27 Jul 2006 07:45:41 +0200
From:	Arnd Bergmann <arnd.bergmann@...ibm.com>
To:	Petr Vandrovec <petr@...drovec.name>
Cc:	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-kernel@...r.kernel.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH] ncpfs: move ioctl32 code to fs/ncpfs/ioctl.c

On Thursday 27 July 2006 05:35, Petr Vandrovec wrote:
> Yes, tomorrow (on amd64).

No need to hurry, I was sitting on my patch for more than a year now ;-)

> Although I understand that this code is correct, what about removing this second 
>   #ifdef ?  gcc should realize it anyway that without CONFIG_COMPAT defined cmd 
> must be equal to NCP_IOC_GETPRIVATEDATA, and having empty "else" variant is IMHO 
> just asking for troubles.

That was what I did first, but unfortunately we don't define compat_caddr_t when
CONFIG_COMPAT is disabled, so it would reference an invalid data structure.

> Or what about 
> 
> #ifdef CONFIG_COMPAT
>      if (cmd == NCP_IOC_GETPRIVATEDATA_32) {
>         struct ...
>      } else
> #endif
>      if (copy_to_user(argp, &user, sizeof(user)))
>         return -EFAULT;

Yes, that should be clearer than my approach.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/