[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20060727002009.GA9390@suse.de>
Date: Wed, 26 Jul 2006 17:20:09 -0700
From: Greg KH <gregkh@...e.de>
To: Arnd Bergmann <arnd@...db.de>
Cc: linux-kernel@...r.kernel.org, greg@...ah.com
Subject: Re: [RFC PATCH] Multi-threaded device probing
On Thu, Jul 27, 2006 at 02:02:00AM +0200, Arnd Bergmann wrote:
> On Tuesday 25 July 2006 22:30, Greg KH wrote:
> > --- gregkh-2.6.orig/include/linux/device.h
> > +++ gregkh-2.6/include/linux/device.h
> > @@ -105,6 +105,8 @@ struct device_driver {
> > ????????void????(*shutdown)?????(struct device * dev);
> > ????????int?????(*suspend)??????(struct device * dev, pm_message_t state);
> > ????????int?????(*resume)???????(struct device * dev);
> > +
> > +???????unsigned int multithread_probe:1;
> > ?};
> > ?
>
> Why use a bit field here? It ends up consuming sizeof(long) anyway
> and causes more complex code, with no obvious benefit.
Because we don't yet have a boolean type :)
Honestly, I don't really care, I can make it a char if people really
care (but due to padding, it would take up the same size as unsigned
long anyway...)
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists