linux-kernel - Re: [PATCH] amd74xx: implement suspend-to-ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154105517.13509.153.camel@localhost.localdomain>
Date:	Fri, 28 Jul 2006 17:51:55 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Andrew Morton <akpm@...l.org>, LKML <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>, Vojtech Pavlik <vojtech@...e.cz>,
	Jason Lunz <lunz@...ooley.org>
Subject: Re: [PATCH] amd74xx: implement suspend-to-ram

Ar Gwe, 2006-07-28 am 16:46 +0200, ysgrifennodd Rafael J. Wysocki:
> From: Jason Lunz <lunz@...ooley.org>
> 
> The amd74xx driver needs to reprogram each drive's PIO timings as well
> as the DMA timings on resume from s2ram.  Otherwise, my
> nforce3-150-based laptop hangs hard when ide_start_power_step() calls
> drive->hwif->ide_dma_check(drive).

NAK

This beings in the IDE power step code. You should do that as a step
before the win_idleimmediate I suspect. Theory is right, diagnosis is
right, implementation is in the wrong place.

You'll make a lot more people happy by fixing it in ide-io

Alan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/