linux-kernel - Re: [patch 1/5] Add comments to the PDA structure to annotate offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154112207.6416.44.camel@laptopd505.fenrus.org>
Date:	Fri, 28 Jul 2006 20:43:27 +0200
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Andi Kleen <ak@...e.de>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [patch 1/5] Add comments to the PDA structure to annotate
	offsets

On Fri, 2006-07-28 at 20:41 +0200, Andi Kleen wrote:
> On Friday 28 July 2006 18:03, Arjan van de Ven wrote:
> > Subject: [patch 1/5] Add comments to the PDA structure to annotate offsets
> > From: Arjan van de Ven <arjan@...ux.intel.com>
> 
> So why exactly do you think these numbers need to be documented?
> 
> If there is a reason there should be a comment in the code.
> 
> Nobody should use fixed numbers, but always get the current ones
> from asm-offset

the 40 one is a gcc ABI one (same offset as userland); that is
documented in the later patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/