[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200607282100.01783.ak@suse.de>
Date: Fri, 28 Jul 2006 21:00:01 +0200
From: Andi Kleen <ak@...e.de>
To: Arjan van de Ven <arjan@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [patch 5/5] Add the -fstack-protector option to the CFLAGS
On Friday 28 July 2006 20:48, Arjan van de Ven wrote:
> On Fri, 2006-07-28 at 20:45 +0200, Andi Kleen wrote:
> > > +ifdef CONFIG_CC_STACKPROTECTOR
> > > +CFLAGS += $(call cc-ifversion, -lt, 0402, -fno-stack-protector)
> > > +CFLAGS += $(call cc-ifversion, -ge, 0402, -fstack-protector)
> >
> > Why can't you just use the normal call cc-option for this?
>
> this requires gcc 4.2; cc-option is not useful for that.
This means nearly nobody can use it. The CC option thing is also
very ugly. Perhaps you really need a Makefile time check like
configure would do for it. Generating a .s and grepping for %gs
would be enough I guess.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists