linux-kernel - Re: 2.6.18-rc2-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bffcb0e0607291638p49d4190cx6d6a39ae84ecff99@mail.gmail.com>
Date:	Sun, 30 Jul 2006 01:38:49 +0200
From:	"Michal Piotrowski" <michal.k.k.piotrowski@...il.com>
To:	"Shailabh Nagar" <nagar@...son.ibm.com>
Cc:	"Matt Helsley" <matthltc@...ibm.com>,
	"Andrew Morton" <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Balbir Singh" <balbir@...ibm.com>
Subject: Re: 2.6.18-rc2-mm1

Hi,

On 30/07/06, Shailabh Nagar <nagar@...son.ibm.com> wrote:
> Matt Helsley wrote:
> > On Fri, 2006-07-28 at 21:53 +0200, Michal Piotrowski wrote:
> >
> >>On 28/07/06, Matt Helsley <matthltc@...ibm.com> wrote:
> >>
> >>>On Fri, 2006-07-28 at 01:34 -0700, Andrew Morton wrote:
> >>>
> >>>>On Fri, 28 Jul 2006 10:17:44 +0200
> >>>>"Michal Piotrowski" <michal.k.k.piotrowski@...il.com> wrote:
> >>>>
> >>>>
> >>>>>Matt, can you look at this?
> >>>>>
> >>>>>My hunt file shows me, that this patches are causing oops.
> >>>>>GOOD
> >>>>>#
> >>>>>#
> >>>>>task-watchers-task-watchers.patch
> >>>>>task-watchers-register-process-events-task-watcher.patch
> >>>>>task-watchers-refactor-process-events.patch
> >>>>>task-watchers-make-process-events-configurable-as.patch
> >>>>>task-watchers-allow-task-watchers-to-block.patch
> >>>>>task-watchers-register-audit-task-watcher.patch
> >>>>>task-watchers-register-per-task-delay-accounting.patch
> >>>>>task-watchers-register-profile-as-a-task-watcher.patch
> >>>>>task-watchers-add-support-for-per-task-watchers.patch
> >>>>>task-watchers-register-semundo-task-watcher.patch
> >>>>>task-watchers-register-per-task-semundo-watcher.patch
> >>>>>BAD
> >>>>
> >>>>Thanks for working that out.
> >>>
> >>>        I noticed the delay accounting functions in the stack trace. Perhaps
> >>>task-watchers-register-per-task-delay-accounting.patch is causing the
> >>>problem.
> >>
> >>Confirmed.
> >
> >
> > Excellent, thanks for the rapid confirmation. I'll work with Shailabh
> > and Balbir to fix this. In the meantime perhaps
> > task-watchers-register-per-task-delay-accounting.patch should be dropped
> > from -mm.
> >
> > Cheers,
> >       -Matt Helsley
> >
>
>
> The error is almost certainly because delayacct_tsk_init is being
> called at WATCH_TASK_CLONE (which is triggered after the task has been
> added to the tasklist) rather than WATCH_INIT (before).
>
> __delayacct_tsk_init, which gets notified by WATCH_TASK_* initializes
> the spinlock tsk->delays_lock which could get used as soon as task is
> present in tasklist. The lockup is very likely due to use of this
> uninitialized spinlock.
>
> So the fix should be to change WATCH_TASK_CLONE to WATCH_TASK_INIT
> in the delayacct_watch_task function created by this patch.

Problem solved. Thanks.

>
> --Shailabh
>

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/