linux-kernel - Re: [RFC][PATCH] Fix lock inversion aio_kick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060729013446.GA3387@kvack.org>
Date:	Fri, 28 Jul 2006 21:34:46 -0400
From:	Benjamin LaHaise <bcrl@...ck.org>
To:	Zach Brown <zach.brown@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-aio@...ck.org,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [RFC][PATCH] Fix lock inversion aio_kick_handler()

On Fri, Jul 28, 2006 at 05:10:32PM -0700, Zach Brown wrote:
> Fix lock inversion aio_kick_handler()

Doh.  Unfortunately, this patch isn't entirely correct as it could race with 
__put_ioctx() which sets ioctx->mm = NULL.  Something like the following 
should do the trick:

	struct mm_struct *mm;
...
> - 	unuse_mm(ctx->mm);
+	mm = ctx->mm;
>  	spin_unlock_irq(&ctx->ctx_lock);
+ 	unuse_mm(mm);
>  	set_fs(oldfs);
>  	/*
...


		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@...ck.org>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/