linux-kernel - Re: [-mm patch] drivers/char/pc8736x_gpio.c: remove unused static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 30 Jul 2006 10:49:23 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	Adrian Bunk <bunk@...sta.de>
CC:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] drivers/char/pc8736x_gpio.c: remove unused static
 functions

Adrian Bunk wrote:
> On Thu, Jul 13, 2006 at 10:48:00PM -0700, Andrew Morton wrote:
>   
>> ...
>> Changes since 2.6.18-rc1-mm1:
>> ...
>> +gpio-drop-vtable-members-gpio_set_high-gpio_set_low.patch
>> ...
>>  Misc fixes and updates and cleanups.
>> ...
>>     
>
> This patch removes two no longer used static functions fixing the 
> following gcc warnings:
>   

Oops.  I thought Id acked this, but it seems not, til now.

> <--  snip  -->
>
> ...
>   CC      drivers/char/pc8736x_gpio.o
> drivers/char/pc8736x_gpio.c:192: warning: #pc8736x_gpio_set_high# defined but not used
> drivers/char/pc8736x_gpio.c:197: warning: #pc8736x_gpio_set_low# defined but not used
> ...
>
> <--  snip  -->
>
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
>   
Acked-by:   Jim Cromie  <jim.cromie@...il.com>
> ---
>
>  drivers/char/pc8736x_gpio.c |   10 ----------
>  1 file changed, 10 deletions(-)
>
> --- linux-2.6.18-rc1-mm2-full/drivers/char/pc8736x_gpio.c.old	2006-07-15 01:38:59.000000000 +0200
> +++ linux-2.6.18-rc1-mm2-full/drivers/char/pc8736x_gpio.c	2006-07-15 01:39:10.000000000 +0200
> @@ -188,16 +188,6 @@
>  	pc8736x_gpio_shadow[port] = val;
>  }
>  
> -static void pc8736x_gpio_set_high(unsigned index)
> -{
> -	pc8736x_gpio_set(index, 1);
> -}
> -
> -static void pc8736x_gpio_set_low(unsigned index)
> -{
> -	pc8736x_gpio_set(index, 0);
> -}
> -
>  static int pc8736x_gpio_current(unsigned minor)
>  {
>  	int port, bit;
>
>
>   

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/