linux-kernel - Re: [Lhms-devel] [Patch] 3/5 in support of hot-add memory x86_64 arch_find_node x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060731171336.B86E.Y-GOTO@jp.fujitsu.com>
Date:	Mon, 31 Jul 2006 17:30:55 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	kmannth@...ibm.com
Cc:	lkml <linux-kernel@...r.kernel.org>, andrew <akpm@...l.org>,
	discuss <discuss@...-64.org>, dave hansen <haveblue@...ibm.com>,
	Andi Kleen <ak@...e.de>, konrad <darnok@...ibm.com>,
	lhms-devel <lhms-devel@...ts.sourceforge.net>,
	kame <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [Lhms-devel] [Patch] 3/5 in support of hot-add memory x86_64 arch_find_node	x86_64

> diff -urN orig/arch/x86_64/mm/srat.c work/arch/x86_64/mm/srat.c
> --- orig/arch/x86_64/mm/srat.c	2006-07-28 13:57:35.000000000 -0400
> +++ work/arch/x86_64/mm/srat.c	2006-07-28 21:19:01.000000000 -0400
> @@ -450,3 +450,15 @@
>  }
>  
>  EXPORT_SYMBOL(__node_distance);
> +
> +int arch_find_node(unsigned long start, unsigned long size) 
> +{
> +	int i, ret = 0;
> +	unsigned long end = start+size;
> +	
> +	for_each_node(i) {
> +		if (nodes_add[i].start <= start && nodes_add[i].end >= end)
> +			ret = i;
> +	}
> +	return ret;
> +}

BTW, does anyone know why nodes_add[] becomes arch dependent code?

I know it is defined in x86-64. But I mean that SRAT is not
arch dependent. It is defined by just ACPI.
However, each arch which uses ACPI has a own code to parse SRAT table.
Is it hard to merge all of them? Are there any special case?

If they can be merged, this code can be written in driver/acpi/numa.c.


Bye.


-- 
Yasunori Goto 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/