linux-kernel - Re: REGRESSION: the new i386 timer code fails to sync CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060731142428.GF3662@kiste.smurf.noris.de>
Date:	Mon, 31 Jul 2006 16:24:28 +0200
From:	Matthias Urlichs <smurf@...rf.noris.de>
To:	Andrew Morton <akpm@...l.org>
Cc:	john stultz <johnstul@...ibm.com>, ak@....de,
	linux-kernel@...r.kernel.org, torvalds@...l.org, bunk@...sta.de,
	lethal@...ux-sh.org, hirofumi@...l.parknet.co.jp,
	asit.k.mallick@...el.com
Subject: Re: REGRESSION: the new i386 timer code fails to sync CPUs

Hi,

Andrew Morton:
> > Hack out the i386 TSC sync code.
> > 
> > diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c
> > index 6f5fea0..cd28914 100644
> > --- a/arch/i386/kernel/smpboot.c
> > +++ b/arch/i386/kernel/smpboot.c
> > @@ -435,7 +435,7 @@ static void __devinit smp_callin(void)
> >  	/*
> >  	 *      Synchronize the TSC with the BP
> >  	 */
> > -	if (cpu_has_tsc && cpu_khz && !tsc_sync_disabled)
> > +	if (0 && cpu_has_tsc && cpu_khz && !tsc_sync_disabled)
> >  		synchronize_tsc_ap();
> >  }
> >  
> > @@ -1305,7 +1305,7 @@ static void __init smp_boot_cpus(unsigne
> >  	/*
> >  	 * Synchronize the TSC with the AP
> >  	 */
> > -	if (cpu_has_tsc && cpucount && cpu_khz)
> > +	if (0 && cpu_has_tsc && cpucount && cpu_khz)
> >  		synchronize_tsc_bp();
> >  }
> 
> I guess Matthias didn't test this patch.  Can we get some obviously-correct
> fix in place for 2.6.18?
> 
This patch doesn't change the problem.

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@...rf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
Success is always being able to wear clothing that you actually like.
-- SJM

Download attachment "signature.asc" of type "application/pgp-signature" (192 bytes)