linux-kernel - [PATCH] mount udf UDF_PART_FLAG_READ_ONLY partitions with MS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <44CE2AAE.7030800@redhat.com>
Date:	Mon, 31 Jul 2006 11:07:10 -0500
From:	Eric Sandeen <esandeen@...hat.com>
To:	linux-kernel@...r.kernel.org
CC:	bfennema@...con.csc.calpoly.edu
Subject: [PATCH] mount udf UDF_PART_FLAG_READ_ONLY partitions with MS_RDONLY

Hi, seems there's a bug where a UDF_PART_FLAG_READ_ONLY udf partition gets 
mounted read-write, then subsequent problems happen; files seem to be able 
to be removed, but file creation results in EIO or worse, oops.

EIO is coming from udf_new_block(), which returns EIO if the right flags 
aren't set; only UDF_PART_FLAG_READ_ONLY is set in this case.  We probably s
hould not have gotten this far...

Attached patch seems to fix it - and includes a printk to alert the user 
that their "rw" mount request has been converted to "ro."

Oh, btw, here's the testcase I used:

[root@...nesium ~]# mkisofs -R -J -udf -o testiso /tmp/
...
Total translation table size: 0
Total rockridge attributes bytes: 342923
Total directory bytes: 382312
Path table size(bytes): 104
Max brk space used 103000
105059 extents written (205 MB)

[root@...nesium ~]# mount -o loop testiso /mnt/test/
[root@...nesium ~]# ls /mnt/test/fsfile
/mnt/test/fsfile
[root@...nesium ~]# rm /mnt/test/fsfile
[root@...nesium ~]# ls /mnt/test/fsfile
ls: /mnt/test/fsfile: No such file or directory
[root@...nesium ~]# touch /mnt/test/fsfile
touch: cannot touch `/mnt/test/fsfile': Input/output error
[root@...nesium tmp]# grep udf /proc/mounts
/dev/loop1 /mnt/test udf rw 0 0 

Thanks,

-Eric

Force readonly mounts of UDF partitions marked as read-only.

Signed-Off-By: Eric Sandeen <sandeen@...deen.net>

Index: linux-2.6.17/fs/udf/super.c
===================================================================
--- linux-2.6.17.orig/fs/udf/super.c
+++ linux-2.6.17/fs/udf/super.c
@@ -1615,6 +1615,10 @@ static int udf_fill_super(struct super_b
 		goto error_out;
 	}
 
+	if (UDF_SB_PARTFLAGS(sb, UDF_SB_PARTITION(sb)) & UDF_PART_FLAG_READ_ONLY)
+		printk("UDF-fs: Partition marked readonly; forcing readonly mount\n");
+		sb->s_flags |= MS_RDONLY;
+
 	if ( udf_find_fileset(sb, &fileset, &rootdir) )
 	{
 		printk("UDF-fs: No fileset found\n");


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/