linux-kernel - Re: [PATCH] x86 built-in command line (resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0607312043030.6762@scrub.home>
Date:	Mon, 31 Jul 2006 20:48:06 +0200 (CEST)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Matt Mackall <mpm@...enic.com>
cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] x86 built-in command line (resend)

Hi,

On Mon, 31 Jul 2006, Matt Mackall wrote:

> +config CMDLINE_BOOL
> +	bool "Default bootloader kernel arguments" if EMBEDDED

You can use a normal depends line here instead of the if.

> +config CMDLINE
> +	string "Initial kernel command string" if EMBEDDED
> +	depends on CMDLINE_BOOL
> +	default "root=/dev/hda1 ro"

This would cause CMDLINE always be set and the simple dependency on 
CMDLINE_BOOL should be enough, so that...

> +#ifdef CONFIG_CMDLINE_BOOL
> +	strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> +#endif

...you only have to test and use CONFIG_CMDLINE here.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/