linux-kernel - Re: [BUG] sched: big numa dynamic sched domain memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060731071242.GA31377@elte.hu>
Date:	Mon, 31 Jul 2006 09:12:42 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Paul Jackson <pj@....com>
Cc:	Nick Piggin <nickpiggin@...oo.com.au>,
	Srivatsa Vaddagiri <vatsa@...ibm.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>, Simon.Derr@...l.net,
	Jack Steiner <steiner@....com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [BUG] sched: big numa dynamic sched domain memory corruption


* Paul Jackson <pj@....com> wrote:

> @@ -5675,12 +5675,13 @@ void build_sched_domains(const cpumask_t
>  		int group;
>  		struct sched_domain *sd = NULL, *p;
>  		cpumask_t nodemask = node_to_cpumask(cpu_to_node(i));
> +		int cpus_per_node = cpus_weight(nodemask);
>  
>  		cpus_and(nodemask, nodemask, *cpu_map);
>  
>  #ifdef CONFIG_NUMA
> -		if (cpus_weight(*cpu_map)
> -				> SD_NODES_PER_DOMAIN*cpus_weight(nodemask)) {
> +		if (cpus_weight(cpu_online_map)
> +				> SD_NODES_PER_DOMAIN*cpus_per_node) {
>  			if (!sched_group_allnodes) {
>  				sched_group_allnodes
>  					= kmalloc(sizeof(struct sched_group)

even if the bug is not fully understood in time, i think we should queue 
the patch above for v2.6.18. (with the small nit that you should put the 
new cpus_per_node variable under CONFIG_NUMA too, to avoid a compiler 
warning)

Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/