linux-kernel - Re: do { } while (0) question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060801014913.5eec556c.akpm@osdl.org>
Date:	Tue, 1 Aug 2006 01:49:13 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, schwidefsky@...ibm.com
Subject: Re: do { } while (0) question

On Tue, 1 Aug 2006 10:21:09 +0200
Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> Hi Andrew,
> 
> your commit e2c2770096b686b4d2456173f53cb50e01aa635c does this:
> 
> ---
> Always use do {} while (0).  Failing to do so can cause subtle compile
> failures or bugs.
> 
> -#define hotcpu_notifier(fn, pri)
> -#define register_hotcpu_notifier(nb)
> -#define unregister_hotcpu_notifier(nb)
> +#define hotcpu_notifier(fn, pri)	do { } while (0)
> +#define register_hotcpu_notifier(nb)	do { } while (0)
> +#define unregister_hotcpu_notifier(nb)	do { } while (0)

<strains brain>

Can't remember.  Maybe it's OK in this case.

Would it be too weazelly to say "because CodingStyle says to"? ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/