linux-kernel - Re: [take2 1/4] kevent: core files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060801143421.GA14827@2ka.mipt.ru>
Date:	Tue, 1 Aug 2006 18:34:21 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	James Morris <jmorris@...ei.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Ulrich Drepper <drepper@...hat.com>,
	netdev <netdev@...r.kernel.org>,
	Zach Brown <zach.brown@...cle.com>
Subject: Re: [take2 1/4] kevent: core files.

On Tue, Aug 01, 2006 at 10:27:36AM -0400, James Morris (jmorris@...ei.org) wrote:
> > > > +	u->ready_num = 0;
> > > > +#ifdef CONFIG_KEVENT_USER_STAT
> > > > +	u->wait_num = u->im_num = u->total = 0;
> > > > +#endif
> > > 
> > > Generally, #ifdefs in the body of the kernel code are discouraged.  Can 
> > > you abstract these out as static inlines?
> > 
> > Yes, it is possible.
> > I would ask is it needed at all?
> 
> Yes, please, it is standard kernel development practice.

Will do.
Thanks, James.

> -- 
> James Morris
> <jmorris@...ei.org>

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/