linux-kernel - Re: [PATCH] simplify update_times (avoid jiffies/jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Aug 2006 23:44:22 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	schwidefsky@...glemail.com
Cc:	johnstul@...ibm.com, akpm@...l.org, zippel@...ux-m68k.org,
	clameter@...r.sgi.com, linux-kernel@...r.kernel.org,
	ralf@...ux-mips.org, ak@....de
Subject: Re: [PATCH] simplify update_times (avoid jiffies/jiffies_64
 aliasing problem)

On Mon, 31 Jul 2006 12:36:38 +0200, "Martin Schwidefsky" <schwidefsky@...glemail.com> wrote:
> > --- a/arch/x86_64/kernel/time.c
> > +++ b/arch/x86_64/kernel/time.c
> > @@ -423,7 +423,8 @@ #endif
> >
> >         if (lost > 0) {
> >                 handle_lost_ticks(lost, regs);
> > -               jiffies += lost;
> > +               while (lost--)
> > +                       do_timer(regs);
> >         }
> >
> >  /*
> 
> I think that this is going into the wrong direction. There are a
> number of architectures that call do_timer(regs) in a while loop. It
> would be much nicer if do_timer would get the number of passed ticks
> as an argument. And the "regs" argument to do_timer is just useless.

But normally do_timer() is called just once, isn't it?  These loops
are just for lost ticks, which would be rarely happened.  So I think
tunning for usual case is better.

I agree that the "regs" argument is useless.  Another candidate for
cleanup.

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/