[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060801193203.GA191@oleg>
Date: Tue, 1 Aug 2006 23:32:03 +0400
From: Oleg Nesterov <oleg@...sign.ru>
To: Nick Piggin <npiggin@...e.de>
Cc: Hugh Dickins <hugh@...itas.com>, Andrew Morton <akpm@...l.org>,
Andy Whitcroft <apw@...dowen.org>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] mm: speculative get_page
Nick Piggin wrote:
>
> --- linux-2.6.orig/mm/vmscan.c
> +++ linux-2.6/mm/vmscan.c
> @@ -380,6 +380,8 @@ int remove_mapping(struct address_space
> if (!mapping)
> return 0; /* truncate got there first */
>
> + SetPageNoNewRefs(page);
> + smp_wmb();
> write_lock_irq(&mapping->tree_lock);
>
Is it enough?
PG_nonewrefs could be already set by another add_to_page_cache()/remove_mapping(),
and it will be cleared when we take ->tree_lock. For example:
CPU_0 CPU_1 CPU_3
add_to_page_cache:
SetPageNoNewRefs();
write_lock_irq(->tree_lock);
...
write_unlock_irq(->tree_lock);
remove_mapping:
SetPageNoNewRefs();
ClearPageNoNewRefs();
write_lock_irq(->tree_lock);
check page_count()
page_cache_get_speculative:
increment page_count()
no PG_nonewrefs => return
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists