linux-kernel - Re: PATCH: Enable binding to local IPv4 IP address for CIFS file system.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <p734pww2skl.fsf@verdi.suse.de>
Date:	01 Aug 2006 20:56:26 +0200
From:	Andi Kleen <ak@...e.de>
To:	Ben Greear <greearb@...delatech.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: PATCH: Enable binding to local IPv4 IP address for CIFS file system.

Ben Greear <greearb@...delatech.com> writes:
> 
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 006eb33..1f34c3f 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -118,6 +118,7 @@ struct TCP_Server_Info {
>   		struct sockaddr_in sockAddr;
>   		struct sockaddr_in6 sockAddr6;
>   	} addr;
> +	u32 ip4_local_ip; /* if != 0, will bind locally to this IP */

adding a ipv4 only, no ipv6 feature like this at this age seems quite
backwards. If anything you should think of easy expansion to IPv6 at least.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/