linux-kernel - Re: Kubuntu's udev broken with 2.6.18-rc2-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200607312301.12140.ajwade@cpe001346162bf9-cm0011ae8cd564.cpe.net.cable.rogers.com>
Date:	Mon, 31 Jul 2006 23:01:09 -0400
From:	Andrew James Wade <andrew.j.wade@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Laurent Riffard <laurent.riffard@...e.fr>,
	Andrew Morton <akpm@...l.org>, andrew.j.wade@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: Kubuntu's udev broken with 2.6.18-rc2-mm1

On Sunday 30 July 2006 23:37, Greg KH wrote:
> On Sun, Jul 30, 2006 at 10:27:06PM -0400, Andrew James Wade wrote:
> > On Sunday 30 July 2006 20:03, Greg KH wrote:
> > > Something's really broken with that version of udev then, because the
> > > 094 version I have running here works just fine with these symlinks.
> > 
> > Maybe, but some really odd things were happening in /sys with the
> > patch. I could still follow the bogus symlinks. More than that
> > 
> > /sys/class/mem/mem$ cd ../../class
> > and
> > /sys/class/mem/mem$ cd ../..
> > 
> > _both_ ended up with a $PWD of /sys/class.

Sorry for the false alarm: I didn't note the previous level of symlinks
in /sys/class/mem, and the subsystem symlinks were actually correct.
The strange behaviour of cd was the result of my shell being to clever
for my own good.

...
> 
> If you want to verify this, please apply the patch at:
> 	http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/device-virtual.patch
> and let me know if it solves your issue (note that the reference
> counting is not completly correct in that patch, that's why I haven't
> unleashed it on -mm yet.)

Unfortunately not. I hand-applied the one reject like so:

diff -rupN 2.6.18-rc2-mm1/drivers/base/core.c linux/drivers/base/core.c
--- 2.6.18-rc2-mm1/drivers/base/core.c	2006-07-31 22:07:24.000000000 -0400
+++ linux/drivers/base/core.c	2006-07-31 15:57:59.000000000 -0400
@@ -368,7 +368,7 @@ static int device_add_class_symlinks(str
 				  dev->bus_id);
 	if (error)
 		goto out_subsys;
-	if (dev->parent) {
+	if ((dev->parent) && (!dev->virtual)) {
 		error = sysfs_create_link(&dev->kobj, &dev->parent->kobj,
 					  "device");
 		if (error)

but udev (79-0ubuntu34) did not work with the patch applied.

thanks,
Andrew Wade
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/