linux-kernel - Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060802071306.GN2654@sequoia.sous-sol.org>
Date:	Wed, 2 Aug 2006 00:13:06 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Zachary Amsden <zach@...are.com>
Cc:	Andi Kleen <ak@...e.de>, virtualization@...ts.osdl.org,
	Andrew Morton <akpm@...l.org>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Jeremy Fitzhardinge <jeremy@...source.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Ian Pratt <ian.pratt@...source.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Christoph Lameter <clameter@....com>
Subject: Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here

* Zachary Amsden (zach@...are.com) wrote:
> Andi Kleen wrote:
> >nst char *arch_vma_name(struct vm_area_struct *vma);
> >  
> >> 
> >>+#ifndef pgd_free_mm
> >>+#define pgd_free_mm(mm) pgd_free((mm)->pgd)
> >>+#endif
> >>    
> >
> >Sorry, but these ifdefs are too ugly. I would prefer if you 
> >just updated all architectures, even though it will make the patch
> >somewhat bigger
> >  
> I'm fine with doing that, and yes this is ugly.  Will take awhile though 
> - for efficiency of mercurial patch tools, I deprecated all 
> architectures but i386, x86_64, and um from my local tree.  <Slaps head>.

While you're at it, can you please make sure there's some nice changelog
comments.  The current one only has diffstat.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/