linux-kernel - Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Aug 2006 01:14:08 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Andi Kleen <ak@...e.de>
Cc:	linux-kernel@...r.kernel.org, Horms <horms@...ge.net.au>,
	Jan Kratochvil <lace@...kratochvil.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Magnus Damm <magnus.damm@...il.com>,
	Vivek Goyal <vgoyal@...ibm.com>, Linda Wang <lwang@...hat.com>
Subject: Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

Andi Kleen <ak@...e.de> writes:

>  
>> The function pointers in the console structure are also a problem.
>> static struct console simnow_console = {
>> 	.name =		"simnow",
>> 	.write =	simnow_write,
>> 	.flags =	CON_PRINTBUFFER,
>> 	.index =	-1,
>> };
>
> Yes just patch them at runtime.

I guess that can work.  It's a bit of a pain though.

>> Ideally the code would be setup so you can compile out consoles
>> the user finds uninteresting.
>
> Seems overkill for early_printk

At least compiling completely out probably isn't.
I have had too many times where the size of a bzImage was an important
factor on a project.
  
>> It is annoying to have to call strlen on all of the strings
>> you want to print..
>
> What strlen? 

The strlen that is needed to convert putstr(char *s) into the
write method for the early_printk helpers.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/