linux-kernel - Re: [patch 3/3] convert CONFIG tag for a few accounting data used by CSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060802003102.c8cb1a47.akpm@osdl.org>
Date:	Wed, 2 Aug 2006 00:31:02 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Jes Sorensen <jes@....com>
Cc:	nagar@...son.ibm.com, jlan@....com, linux-kernel@...r.kernel.org,
	balbir@...ibm.com, csturtiv@....com, tee@....com
Subject: Re: [patch 3/3] convert CONFIG tag for a few accounting data used
 by CSA

On Wed, 02 Aug 2006 09:26:02 +0200
Jes Sorensen <jes@....com> wrote:

> Shailabh Nagar wrote:
> > Jay Lan wrote:
> >> There were a few accounting data/macros that are used in CSA
> >> but are #ifdef'ed inside CONFIG_BSD_PROCESS_ACCT. This patch is
> >> to change those ifdef's from CONFIG_BSD_PROCESS_ACCT to
> >> CONFIG_CSA_ACCT. A few defines are moved from kernel/acct.c and
> >> include/linux/acct.h to kernel/csa.c and include/linux/csa_kern.h.
> >>
> >>
> >> Signed-off-by:  Jay Lan <jlan@....com>
> 
> [snip]
> 
> >> +#ifdef CONFIG_CSA_ACCT
> >> +extern void acct_update_integrals(struct task_struct *tsk);
> >> +extern void acct_clear_integrals(struct task_struct *tsk);
> >> +#else
> >> +#define acct_update_integrals(x)	do { } while (0)
> >> +#define acct_clear_integrals(task)	do { } while (0)
> >> +#endif
> >> +
> > 
> > static inlines preferred
> 
> Huh? Is that a preference to the taskstat project? For the kernel
> itself it makes no difference.

static inlines provide typechecking and typo checking and presence-of-x
checking when the option is configged off.  They can also suppress unused
variable warnings.

And they're C, not cpp ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/