linux-kernel - Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154479684.2570.14.camel@localhost.localdomain>
Date:	Wed, 02 Aug 2006 10:48:04 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andi Kleen <ak@...e.de>
Cc:	virtualization@...ts.osdl.org, Andrew Morton <akpm@...l.org>,
	Ian Pratt <ian.pratt@...source.com>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	Chris Wright <chrisw@...s-sol.org>,
	Christoph Lameter <clameter@....com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear
	address space for hypervisors

On Tue, 2006-08-01 at 23:47 +0200, Andi Kleen wrote:
>  > +		/*
> > +		 * reservedtop=size reserves a hole at the top of the kernel
> > +		 * address space which a hypervisor can load into later.
> > +		 * Needed for dynamically loaded hypervisors, so relocating
> > +		 * the fixmap can be done before paging initialization.
> > +		 * This hole must be a multiple of 4M.
> > +		 */
> > +		else if (!memcmp(from, "reservedtop=", 12)) {
> > +			unsigned long reserved = memparse(from+12, &from);
> > +			reserved &= ~0x3fffff;
> > +			set_fixaddr_top(-reserved);
> > +		}
> 
> You need to add a dummy __setup for it, otherwise it will end up in
> init's environments or be warned about.

Ewww, it's not the only one.  This whole function should be replaced
with a whole heap of early_param()s and a call to parse_early_param().

I only implemented parse_early_param two years ago; maybe it is time for
i386 to use it...

I'll create a patch,
Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/