| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Aug 2006 17:21:09 +0100 From: Russell King <rmk+lkml@....linux.org.uk> To: Haavard Skinnemoen <hskinnemoen@...el.com> Cc: Andrew Victor <andrew@...people.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] at91_serial: Fix break handling On Wed, Aug 02, 2006 at 06:14:03PM +0200, Haavard Skinnemoen wrote: > On Wed, 2 Aug 2006 16:17:41 +0100 > Russell King <rmk+lkml@....linux.org.uk> wrote: > > 2. it breaks break handling. uart_handle_break returns a value for a > > reason. Use it - don't unconditionally ignore the received > > character. > > Ok, I'll fix it. > > Out of curiosity, why does it return a value? ;) Because you may or may not need to ignore the received character! When a break condition occurs which is not ignored by the termios settings, you need to insert a TTY_BREAK indicator into the tty received queue, so that the tty layers and userspace can do the right thing. There is the requirement for errors to be passed to userspace if userspace has requested that behaviour. However, if this is the serial console with sysrq support, then break is masked by that and needs to be ignored. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists