linux-kernel - Re: [PATCH v3] ifdef blktrace debugging fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060802051844.GF20108@suse.de>
Date:	Wed, 2 Aug 2006 07:18:45 +0200
From:	Jens Axboe <axboe@...e.de>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ifdef blktrace debugging fields

On Wed, Aug 02 2006, Alexey Dobriyan wrote:
> On Tue, Aug 01, 2006 at 10:12:57PM +0200, Jens Axboe wrote:
> > > +#ifdef CONFIG_BLK_DEV_IO_TRACE
> > >  	if (q->blk_trace)
> > >  		blk_trace_shutdown(q);
> > > -
> > > +#endif
> > >  	kmem_cache_free(requestq_cachep, q);
> > >  }
> >
> > That can be made ifdef less, if you unconditionally call
> > blk_trace_shutdown() and just make that one do:
> >
> >         if (q->blk_trace) {
> >                 ...
> >         }
> >
> > since that'll then do the right always. Please make that change, then
> > I'm fine with the patch.
> 
> OK here goes version 3.
> 
> [PATCH] ifdef blktrace debugging fields

Looks good!

Acked-by: Jens Axboe <axboe@...e.de>

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/