linux-kernel - Re: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154496058.2570.57.camel@localhost.localdomain>
Date:	Wed, 02 Aug 2006 15:20:57 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andi Kleen <ak@...e.de>
Cc:	Andrew Morton <akpm@...l.org>,
	Xen-devel <xen-devel@...ts.xensource.com>,
	virtualization@...ts.osdl.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Ian Pratt <ian.pratt@...source.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Christoph Lameter <clameter@....com>
Subject: Re: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve
	high linear address space for hypervisors

On Wed, 2006-08-02 at 06:36 +0200, Andi Kleen wrote:
> Please just make a proper patch - either add a call to it to all setup_archs,
> or add a call to before setup_arch in init/main.c. While such ifdefs
> for specific architecture hacks are more popular lately it doesn't mean they are a good idea.

It's been around for two years, but if you fix x86_64 to use
early_param(), and I'll patch the other setup_archs to call
parse_early_param and remove the init/main.c call 8)

> I hope there aren't any existing architectures that use it in the middle
> of setup_arch or rely on it being after setup_arch.

setup_arch is responsible for grabbing the command line, so that has to
happen first.  Even on x86, functions later in setup_arch rely on
cmdline parsing having happened.  So for the moment setup_arch has to
call parse_early_param.

Maybe one day we can create a new "char *arch_get_cmdline()", implement
that everywhere, then call it and parse_early_param from core code.  But
baby steps...

Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/