linux-kernel - Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200608020744.40888.ak@suse.de>
Date:	Wed, 2 Aug 2006 07:44:40 +0200
From:	Andi Kleen <ak@...e.de>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	linux-kernel@...r.kernel.org, Horms <horms@...ge.net.au>,
	Jan Kratochvil <lace@...kratochvil.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Magnus Damm <magnus.damm@...il.com>,
	Vivek Goyal <vgoyal@...ibm.com>, Linda Wang <lwang@...hat.com>
Subject: Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

 
> The function pointers in the console structure are also a problem.
> static struct console simnow_console = {
> 	.name =		"simnow",
> 	.write =	simnow_write,
> 	.flags =	CON_PRINTBUFFER,
> 	.index =	-1,
> };

Yes just patch them at runtime.


> Ideally the code would be setup so you can compile out consoles
> the user finds uninteresting.

Seems overkill for early_printk
 
> It is annoying to have to call strlen on all of the strings
> you want to print..

What strlen? 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/