linux-kernel - Re: [PATCH] tty: add ioctl for setting the throttle threshold (handshake)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1154611500.23655.75.camel@localhost.localdomain>
Date:	Thu, 03 Aug 2006 14:25:00 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dirk Eibach <eibach@...ys.de>
Cc:	rmk+serial@....linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: add ioctl for setting the throttle threshold
	(handshake)

Ar Iau, 2006-08-03 am 14:53 +0200, ysgrifennodd Dirk Eibach:
> To be more flexible ioctls were added to control the throttling thresholds.
> 
> This patch applies to kernel 2.6.16.
> 
> Signed-off-by: Dirk Eibach <eibach@...ys.de>

NAK

Two reasons

#1 Users should not be expected to set these kind of parameters, the
kernel should just get it right
#2 With the new buffering if you respond too slowly then thats allowed
for (with a limit enforced in the patch I posted)

Those two alone aren't quite enough to deal with some corner cases where
you throttle too late and queue an oversized buffer. The changes in
2.6.18-rc by Paul however ensure that such a buffer is fed into the
ldisc in appropriate sized chunks to avoid data loss.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/