[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060803144249.GE920@infradead.org>
Date: Thu, 3 Aug 2006 15:42:49 +0100
From: Christoph Hellwig <hch@...radead.org>
To: Dave Hansen <haveblue@...ibm.com>
Cc: linux-kernel@...r.kernel.org, viro@....linux.org.uk,
herbert@...hfloor.at, hch@...radead.org
Subject: Re: [PATCH 27/28] elevate writer count for custom 'struct file'
On Tue, Aug 01, 2006 at 04:53:00PM -0700, Dave Hansen wrote:
>
> Some filesystems forego the vfs and may_open() and create their
> own 'struct file's. Any of these users which set the write flag
> on the file will cause an extra mnt_drop_write() on __fput(),
> thus dropping the reference count too low.
>
> These users tend to have artifical in-kernel vfsmounts which
> aren't really exposed to userspace and can't be remounted, but
> this patch is included for completeness and so that the warnings
> don't trip over these cases.
Please add a helper to create these files so all this happens in just
one place. There's a fare bit of code duplication already that this will
cleanup. Another nice cleanup you should push out first before doing
the actual feature :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists