linux-kernel - Re: don't taint UP K7's running SMP kernels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1154639072.23655.122.camel@localhost.localdomain>
Date:	Thu, 03 Aug 2006 22:04:32 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dave Jones <davej@...hat.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: don't taint UP K7's running SMP kernels.

Ar Iau, 2006-08-03 am 14:32 -0400, ysgrifennodd Dave Jones:
> We have a test that looks for invalid pairings of certain athlon/durons
> that weren't designed for SMP, and taint accordingly (with 'S') if we find
> such a configuration.  However, this test shouldn't fire if there's only
> a single CPU present. It's perfectly valid for an SMP kernel to boot on UP
> hardware for example.
> 
> Signed-off-by: Dave Jones <davej@...hat.com>
> 
> --- linux-2.6/arch/i386/kernel/smpboot.c~	2006-08-03 14:29:47.000000000 -0400
> +++ linux-2.6/arch/i386/kernel/smpboot.c	2006-08-03 14:30:43.000000000 -0400
> @@ -177,6 +177,9 @@ static void __devinit smp_store_cpu_info
>  	 */
>  	if ((c->x86_vendor == X86_VENDOR_AMD) && (c->x86 == 6)) {
>  
> +		if (num_online_cpus() == 1)
> +			goto valid_k7;
> +
>  		/* Athlon 660/661 is valid. */	
>  		if ((c->x86_model==6) && ((c->x86_mask==0) || (c->x86_mask==1)))
>  			goto valid_k7;

Acked-by: Alan Cox <alan@...hat.com>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/