linux-kernel - Re: [PATCH] eicon: fix define conflict with ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Aug 2006 16:36:30 +0200 (CEST)
From:	Armin Schindler <armin@...ware.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eicon: fix define conflict with ptrace

On Thu, 3 Aug 2006, Alan Cox wrote:
> Ar Gwe, 2006-08-04 am 00:34 +0400, ysgrifennodd Alexey Dobriyan:
> > * MODE_MASK is unused in eicon driver.
> > * Conflicts with a ptrace stuff on arm.
> > 
> > drivers/isdn/hardware/eicon/divasync.h:259:1: warning: "MODE_MASK" redefined
> > include2/asm/ptrace.h:48:1: warning: this is the location of the previous definition
> > 
> > Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> 
> NAK. You need to fix all the code expecting to use the MODE_MASK with a
> value of 0x00000080

The definitions in drivers/isdn/hardware/eicon/divasync.h are for
Eicon driver only. Since MODE_MASK is not really used in the Eicon/Divas 
driver, the removal from this file is okay.

Armin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/