linux-kernel - Re: 2.6.18-rc3-g3b445eea BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0608041222400.5167@g5.osdl.org>
Date:	Fri, 4 Aug 2006 12:24:57 -0700 (PDT)
From:	Linus Torvalds <torvalds@...l.org>
To:	Michal Piotrowski <michal.k.k.piotrowski@...il.com>
cc:	Dave Jones <davej@...emonkey.org.uk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.18-rc3-g3b445eea BUG: warning at
 /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug()

On Fri, 4 Aug 2006, Michal Piotrowski wrote:
> 
> This was reported
> http://www.ussg.iu.edu/hypermail/linux/kernel/0607.3/1867.html
> http://www.ussg.iu.edu/hypermail/linux/kernel/0608.0/0675.html
> 
> It's time to use git-bisect.
> 
> BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug()

Ok, that really is a pretty scary thing. The warning happens if the lock 
is released by somebody else than the person who took it. I don't _think_ 
that's supposed to happen, but with cpu hotplug locking being as 
"creative" as it is, maybe it's valid. 

I was planning on shutting the cpu hotplug warnings up for v2.6.18 - at 
least the "lukewarm IQ" one for _taking_ the lock recursively. But I had 
planned on leaving the unlock_cpu_hotplug() in place, since up until now 
it hadn't triggered, and it really smells like a bug if it does.

> [<c0132a04>] unlock_cpu_hotplug+0x2c/0x54
> [<c013a2ec>] stop_machine_run+0x2e/0x34
> [<c0135686>] sys_init_module+0x15a0/0x178a
> [<c015b7b7>] do_sync_read+0xb6/0xf1
> [<c0102d51>] sysenter_past_esp+0x56/0x79

DaveJ, any ideas?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/