lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <44D3D8F9.2070602@linux.intel.com>
Date:	Fri, 04 Aug 2006 16:32:09 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Jiri Slaby <slaby@...erouter.org>
CC:	liyu <liyu@...ss.com.cn>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: The HID Simple Driver Interface 0.3.0


>> Signed-off-by: Liyu <liyu@...ss.com.cn>
>>
>> diff -Naurp linux-2.6.17.7/drivers/usb/input.orig/hid-core.c linux-2.6.17.7/drivers/usb/input/hid-core.c
>> --- linux-2.6.17.7/drivers/usb/input.orig/hid-core.c	2006-07-25 11:36:01.000000000 +0800
>> +++ linux-2.6.17.7/drivers/usb/input/hid-core.c	2006-08-03 15:44:45.000000000 +0800
>> @@ -4,6 +4,7 @@
>>   *  Copyright (c) 1999 Andreas Gal
>>   *  Copyright (c) 2000-2005 Vojtech Pavlik <vojtech@...e.cz>
>>   *  Copyright (c) 2005 Michael Haboustak <mike-@...ci.rr.com> for Concept2, Inc
>> + *  Copyright (c) 2006 Liyu <liyu@...ss.com.cn>  HID simple driver interface
>>   */
>>  
>>  /*
>> @@ -26,6 +27,7 @@
>>  #include <asm/byteorder.h>
>>  #include <linux/input.h>
>>  #include <linux/wait.h>
>> +#include <asm/semaphore.h>
>>  

Hi,

btw I just noticed this, but please use mutexes not semaphores in new code. Sorry for not
noticing this earlier, I'll need to adjust my filters I suspect.

Greetings,
   Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ