linux-kernel - Re: [PATCH] memory hotadd fixes [6/5] enhance collistion check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060804121950.b3227092.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 4 Aug 2006 12:19:50 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	kmannth@...ibm.com
Cc:	akpm@...l.org, y-goto@...fujitsu.com, linux-kernel@...r.kernel.org,
	lhms-devel@...ts.sourceforge.net
Subject: Re: [PATCH] memory hotadd fixes [6/5] enhance collistion check

On Thu, 03 Aug 2006 20:09:42 -0700
keith mannthey <kmannth@...ibm.com> wrote:
> >  	pg_data_t *pgdat = NULL;
> >  	int new_pgdat = 0;
> > +	struct resource *res;
> >  	int ret;
> >  
> > +	res = register_memory_resource(start, size);
> > +	if (!res)
> > +		return -EEXIST;
> > +
> >  	if (!node_online(nid)) {
> >  		pgdat = hotadd_new_pgdat(nid, start);
> >  		if (!pgdat)
> > @@ -277,14 +293,13 @@
> >  		BUG_ON(ret);
> >  	}
> >  
> > -	/* register this memory as resource */
> > -	ret = register_memory_resource(start, size);
> > -
> >  	return ret;
> >  error:
> >  	/* rollback pgdat allocation and others */
> >  	if (new_pgdat)
> >  		rollback_node_hotadd(nid, pgdat);
> > +	if (res)
> > +		release_memory_resource(res);
> >  
> 
> 
> I am trying to keep add_memory non-sparsemem specific.  With reserve
> memory the memory is already present and so using
> register_memory_resource as a key to find out if it is already present
> won't work.
> 
Hm, okay. looks your help is necessary.

> I can build ontop of this if you want me to.  I would like to test this
> to make sure it works for me. (I will do this sometime today)
> 
Thanks!
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/