linux-kernel - Re: [PATCH] memory hotadd fixes [3/5] find_next_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1154650093.5925.42.camel@keithlap>
Date:	Thu, 03 Aug 2006 17:08:12 -0700
From:	keith mannthey <kmannth@...ibm.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	lhms-devel <lhms-devel@...ts.sourceforge.net>,
	"y-goto@...fujitsu.com" <y-goto@...fujitsu.com>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] memory hotadd fixes [3/5] find_next_system_ram catch
	range fix

On Thu, 2006-08-03 at 12:34 +0900, KAMEZAWA Hiroyuki wrote:
>  find_next_system_ram() is used to find available memory resource
> at onlining newly added memory.
> This patch fixes following problem.
> 
> find_next_system_ram() cannot catch this case.
> 
> Resource:      (start)-------------(end)
> Section :                (start)-------------(end)
> 
> 
> Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
>  kernel/resource.c   |    3 ++-
>  mm/memory_hotplug.c |    2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.18-rc3/kernel/resource.c
> ===================================================================
> --- linux-2.6.18-rc3.orig/kernel/resource.c	2006-08-01 16:38:45.000000000 +0900
> +++ linux-2.6.18-rc3/kernel/resource.c	2006-08-01 16:38:56.000000000 +0900
> @@ -244,6 +244,7 @@
>  
>  	start = res->start;
>  	end = res->end;
> +	BUG_ON(start >= end);

BUG_ON seems a little strong for bad arguments to the function but I am
ok with it. 

Thanks,
 Keith 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/